[21768] DDS data publication implementation#2
Closed
juanlofer-eprosima wants to merge 21 commits into
Closed
Conversation
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
…r when it fails. Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
changed the title
EugenioCollado
self-requested a review
January 10, 2025 10:59
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
| utils::ReturnCode reload_configuration( | ||
| yaml::EnablerConfiguration& new_configuration); | ||
|
|
||
| // TODO |
| @@ -50,6 +50,8 @@ This callback is invoked by the ``CBHandler`` through the ``CBWriter`` class. | |||
| const char* topicName, | |||
| const char* serializedType); | |||
|
|
|||
| .. TODO: update with topic notification, topic request and type request callbacks | |||
Contributor
Author
There was a problem hiding this comment.
I think we can leave this to do for a dedicated PR updating the documentation.
Contributor
Author
|
Closed in favor of #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after:
This branch is also on top of
feature/json_config, probably should create a dedicated PR adding that capability.